.gitea/workflows/services.yml aktualisiert

.gitea/workflows/services.yml

@@ -1,36 +1,43 @@
 name: Test Gitea Actions with Service Containers
-on:
-  push:
-    branches:
-      - master
+on: push
 
 env:
   # Global Env Variables readable in all jobs of this workflow
-  MONGODB_CLUSTER_ADDRESS: mongodb
+  MONGODB_CLUSTER_ADDRESS: mongodb # The network alias name of the mongodb docker service container
+  # Env Variables which the Example JS App will access
   MONGODB_USERNAME: root
   MONGODB_PASSWORD: supersecretpassword
-  MONGODB_DB_NAME: actions-environment
+  MONGODB_DB_NAME: actionsenvironment
   PORT: 8080
 
 jobs:
   build:
+    # Job will execute the Steps inside a 'node:latest' docker container
+    container:
+      image: node:latest
     runs-on: ubuntu-latest
     services:
+        # Before running the Steps of this job...
+        # The runner will spawm a second container 'mongodb' using the mongo:latest image with some db settings
+        # The node container and the mongodb container will be in a new temporary docker bridge network 
         mongodb:
-            image: mongodb
+            image: mongo:latest
+            # Docker related container env Variables for the mongo image (JS App will not have these variables)
             env:
+                MONGO_INITDB_DATABASE: actionsenvironment
                 MONGO_INITDB_ROOT_USERNAME: root
                 MONGO_INITDB_ROOT_PASSWORD: supersecretpassword
+
     steps:
-      - name: Get Code
-        uses: actions/checkout@v3
       - name: Install NodeJS
         uses: actions/setup-node@v3
         with:
           node-version: '18'
+      - name: Get Code
+        uses: actions/checkout@v3
       - name: Install dependencies
         run: npm ci
       - name: Run server
-        run: npm start & npx wait-on http://127.0.0.1:$WEB_PORT
+        run: npm start & npx wait-on http://127.0.0.1:$PORT
       - name: Run tests
         run: npm test

data/database.js

@@ -1,21 +1,21 @@
 import { MongoClient } from 'mongodb';
 
-const connectionProtocol = process.env.MONGODB_CONNECTION_PROTOCOL;
 const clusterAddress = process.env.MONGODB_CLUSTER_ADDRESS;
 const dbUser = process.env.MONGODB_USERNAME;
 const dbPassword = process.env.MONGODB_PASSWORD;
 const dbName = process.env.MONGODB_DB_NAME;
 
-const uri = `${connectionProtocol}://${dbUser}:${dbPassword}@${clusterAddress}/?retryWrites=true&w=majority`;
+const uri = `mongodb://${dbUser}:${dbPassword}@${clusterAddress}/?retryWrites=true&w=majority`;
 const client = new MongoClient(uri);
 
-console.log('Trying to connect to db');
+console.log('Trying to connect to db: ' + uri);
 
 try {
   await client.connect();
   await client.db(dbName).command({ ping: 1 });
   console.log('Connected successfully to server');
 } catch (error) {
+  console.log(error)
   console.log('Connection failed.');
   await client.close();
   console.log('Connection closed.');